Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 16, 2024

First converting a diesel::result::Error to a BoxedAppError only to then rely on downcasting to check the content of the original error seems a bit over-complicated. This PR replaces the check with a much simpler is_read_only_error() fn and then gets rid of the ReadOnlyMode struct in favor of another custom() error helper call.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 16, 2024
@codecov
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.20%. Comparing base (7788b02) to head (f8ee4b6).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/controllers/user/session.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9968   +/-   ##
=======================================
  Coverage   89.20%   89.20%           
=======================================
  Files         292      293    +1     
  Lines       30380    30374    -6     
=======================================
- Hits        27100    27095    -5     
+ Misses       3280     3279    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit c31cbb1 into rust-lang:main Nov 16, 2024
10 checks passed
@Turbo87 Turbo87 deleted the read-only branch November 16, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant