Skip to content

replace i686-unknown-linux-gnu in default target list with aarch64-unknown-linux-gnu #2943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

replace i686-unknown-linux-gnu in default target list with aarch64-unknown-linux-gnu #2943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/metadata/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ pub const HOST_TARGET: &str = env!("DOCSRS_METADATA_HOST_TARGET");
/// [tier one]: https://doc.rust-lang.org/nightly/rustc/platform-support.html#tier-1
pub const DEFAULT_TARGETS: &[&str] = &[
"i686-pc-windows-msvc",
"i686-unknown-linux-gnu",
"aarch64-unknown-linux-gnu",
"aarch64-apple-darwin",
"x86_64-pc-windows-msvc",
"x86_64-unknown-linux-gnu",
Expand Down
4 changes: 2 additions & 2 deletions src/docbuilder/rustwide_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1473,8 +1473,8 @@ mod tests {
targets,
vec![
"aarch64-apple-darwin",
"aarch64-unknown-linux-gnu",
"i686-pc-windows-msvc",
"i686-unknown-linux-gnu",
"x86_64-pc-windows-msvc",
"x86_64-unknown-linux-gnu",
]
Expand Down Expand Up @@ -1675,7 +1675,7 @@ mod tests {
serde_json::Value::Array(vec![]),
vec![
"i686-pc-windows-msvc".into(),
"i686-unknown-linux-gnu".into(),
"aarch64-unknown-linux-gnu".into(),
"aarch64-apple-darwin".into(),
"x86_64-pc-windows-msvc".into(),
"x86_64-unknown-linux-gnu".into(),
Expand Down
6 changes: 3 additions & 3 deletions src/web/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,11 +990,11 @@ mod test {
let web = env.web_app().await;
web.assert_redirect("/bat/0.2.0", "/crate/bat/0.2.0")
.await?;
web.assert_redirect("/bat/0.2.0/i686-unknown-linux-gnu", "/crate/bat/0.2.0")
web.assert_redirect("/bat/0.2.0/aarch64-unknown-linux-gnu", "/crate/bat/0.2.0")
.await?;
/* TODO: this should work (https://github.com/rust-lang/docs.rs/issues/603)
assert_redirect("/bat/0.2.0/i686-unknown-linux-gnu/bat", "/crate/bat/0.2.0", web)?;
assert_redirect("/bat/0.2.0/i686-unknown-linux-gnu/bat/", "/crate/bat/0.2.0/", web)?;
assert_redirect("/bat/0.2.0/aarch64-unknown-linux-gnu/bat", "/crate/bat/0.2.0", web)?;
assert_redirect("/bat/0.2.0/aarch64-unknown-linux-gnu/bat/", "/crate/bat/0.2.0/", web)?;
*/
Ok(())
})
Expand Down
2 changes: 1 addition & 1 deletion templates/core/Cargo.toml.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ default-target = "x86_64-unknown-linux-gnu"
# - x86_64-unknown-linux-gnu
# - aarch64-apple-darwin
# - x86_64-pc-windows-msvc
# - i686-unknown-linux-gnu
# - aarch64-unknown-linux-gnu
# - i686-pc-windows-msvc
#
# Set this to `[]` to only build the default target.
Expand Down
Loading