Skip to content

Conversation

@syphar
Copy link
Member

@syphar syphar commented Nov 15, 2025

Multiple parts:

  1. we do a first decompression test by buffering some first bytes from the decompressed stream directly
  2. In case of errors when fetching files from archives, we'll just delete the local cache and try again

This is only a last resort. Generally I want to find all race conditions with the caching, prioritized by how often they happen. The other cases are hopefully caught by this logic.

Errors where this will help:

I also have an idea how to restructure the whole archive index thing so people don't have to think about locking.

@syphar syphar requested a review from a team as a code owner November 15, 2025 15:22
@syphar syphar self-assigned this Nov 15, 2025
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Nov 15, 2025
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me apart from potential nit.

@syphar syphar merged commit f953a7f into rust-lang:master Nov 15, 2025
16 checks passed
@syphar syphar deleted the validate branch November 15, 2025 16:59
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants