Skip to content

Conversation

@syphar
Copy link
Member

@syphar syphar commented Dec 2, 2025

needs rust-lang/simpleinfra#832 to be merged & applied before deploying, so the collector doesn't run wild. thanks @marcoieni !

This also removes the "crates / releases / targets visited" metrics. I didn't look at them for quite some time. There was an initial learning we had (= most requests are crawlers), but nothing else after that, so we can safe the processing time & memory.

If we feel like adding it back, we easily can.

@syphar syphar requested a review from a team as a code owner December 2, 2025 01:25
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Dec 2, 2025
@syphar syphar self-assigned this Dec 2, 2025
@syphar syphar force-pushed the remove-prometheus branch from 6abc2cc to 965de03 Compare December 2, 2025 01:33
@syphar syphar changed the title remove prometheus metrics from docs.rs remove prometheus metrics Dec 2, 2025
@GuillaumeGomez
Copy link
Member

Seems like you forgot to update a docker file.

@syphar
Copy link
Member Author

syphar commented Dec 2, 2025

Seems like you forgot to update a docker file.

can you see the actual error? I seem to miss it in the logs

@GuillaumeGomez
Copy link
Member

No, just:

container docsrs-web-1 is unhealthy
error: Recipe `compose-up` failed on line 4 with exit code 1
error: Recipe `compose-up-web` failed on line 9 with exit code 1

So I just assumed (maybe incorrectly) that a docker image needed to be updated.

@syphar
Copy link
Member Author

syphar commented Dec 2, 2025

odd. I'll try locally

@syphar
Copy link
Member Author

syphar commented Dec 2, 2025

ah, I think I know why

@syphar
Copy link
Member Author

syphar commented Dec 2, 2025

I used the metrics endpoints as health-checks for most containers :)

@GuillaumeGomez
Copy link
Member

So I was right, yeay me. \o/

@GuillaumeGomez
Copy link
Member

Looks good to me, thanks!

@syphar
Copy link
Member Author

syphar commented Dec 2, 2025

Looks good to me, thanks!

I'll still wait until CI passes :)

@syphar syphar merged commit 834153a into rust-lang:main Dec 2, 2025
14 of 17 checks passed
@syphar syphar deleted the remove-prometheus branch December 2, 2025 13:42
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Dec 2, 2025
@syphar
Copy link
Member Author

syphar commented Dec 2, 2025

just confirmed again by @marcoieni : rust-lang/simpleinfra#832 is applied, the collectors don't collect any more.

@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants