add Sender::is_closed method #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
sender-is-closed
branch
from
c15fdd0 to
11e7bb9
Compare
Contributor
Author
|
Any thoughts on the point in the description comment? |
Member
|
About the naming of close? Maybe |
Member
|
Or you could keep with the pattern used in some of the other methods and have |
Contributor
Author
|
Of course, closing an mpsc channel has no error case, so it could just be |
Member
|
Seems fine to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It useful to be able to check if the channel is closed without registered to a task.
I didn't do it in this PR because I'm unsure of the name, but it's related: as mention in #775, it would be useful to close a channel from a
Sender. I'm not sure if it should be required to have aContext, like withpoll_close, so that someone could signal a close in another thread, but I'm sure the namecloseis reserved to be the mini-future forpoll_closethat borrows self.