Skip to content

Either fixes #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2018
Merged

Either fixes #972

merged 2 commits into from
Apr 18, 2018

Conversation

@cramertj
Copy link
Member

@cramertj cramertj commented Apr 18, 2018 •
edited
Loading

.left and .right overlap w/ the inherent methods on the Either type, which makes chaining painful (e.g. you need Either::right(fut.left()) rather than fut.left().right()).

This also adds an either impl for Sink.

@cramertj cramertj requested review from alexcrichton and aturon April 18, 2018 16:33
@aturon
Copy link
Contributor

aturon commented Apr 18, 2018

r+

@aturon aturon merged commit 0c08606 into rust-lang:master Apr 18, 2018
@cramertj cramertj deleted the either-fix branch April 18, 2018 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcrichton alexcrichton Awaiting requested review from alexcrichton

1 more reviewer

@aturon aturon aturon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cramertj @aturon