Skip to content

Add lconv type, and locale support for UNIX #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 31, 2016
Merged

Add lconv type, and locale support for UNIX #244

merged 8 commits into from
Mar 31, 2016

Conversation

@mrhota
Copy link
Contributor

@mrhota mrhota commented Mar 30, 2016

We have lconv struct, setlocale(), and localeconv(). Constants live
under notbsd for now.

@mrhota
Add lconv type, and locale support for UNIX
110152c 
We have lconv struct, setlocale(), and localeconv(). Constants live
under notbsd for now.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

mrhota added 2 commits March 30, 2016 00:55
@mrhota
Fix long line
2bd6f12 
Lint caught a long line. This should fix the CI failure.
@mrhota
Add locale.h in libc-test
b788a5c
@mrhota
Copy link
Contributor Author

mrhota commented Mar 30, 2016

looks like I need to pull the struct lconv def down into the tree. NetBSD, Apple, and musl didn't seem to like the layout of the struct.

@mrhota
Copy link
Contributor Author

mrhota commented Mar 30, 2016

musl doesn't define the additional locale categories, LC_NAME, LC_IDENTIFICATION, LC_ADDRESS, LC_MEASUREMENT, LC_PAPER, and LC_TELEPHONE. The const defs need to be pulled down lower in the hierarchy.

@mrhota mrhota mentioned this pull request Mar 30, 2016
Closed
@alexcrichton
Copy link
Member

Yeah this all looks good to me once the CI is passing

mrhota added 5 commits March 30, 2016 19:49
@mrhota
Fix lconv field offsets for apple-likes
912a7a0
@mrhota
Pull lconv def down into notbsd
874852c
@mrhota
Define struct and consts for bsds
0dc7176 
The BSDs seem to have more peculiarities than the notbsds
@mrhota
Define struct and consts for notbsds
5a0c067 
Linux-likes have more locale categories than the BSDs (except for
musl). We define the common set of categories at the
src/unix/notbsd/mod.rs level, and leave the rest to the
platform-specific modules.
@mrhota
Change netbsd link_name for setlocale
5399c89
@mrhota
Copy link
Contributor Author

mrhota commented Mar 31, 2016

@alexcrichton I pushed the defs around, expanding the size of this addition quite a bit. I'm not sure if I should be concerned about the obvious duplication between some platforms.

@alexcrichton
Copy link
Member

@bors: r+ 5399c89

Looks good to me, thanks @mrhota! No need to worry about duplication, that's just an inevitability of libc :)

@bors
Copy link
Contributor

bors commented Mar 31, 2016

⌛ Testing commit 5399c89 with merge 8f50721...

bors added a commit that referenced this pull request Mar 31, 2016
@bors
Auto merge of #244 - mrhota:basic_locale, r=alexcrichton
8f50721 
Add lconv type, and locale support for UNIX

We have lconv struct, setlocale(), and localeconv(). Constants live
under notbsd for now.
@bors
Copy link
Contributor

bors commented Mar 31, 2016

💔 Test failed - travis

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Mar 31, 2016 at 10:09 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - travis
https://travis-ci.org/rust-lang/libc/builds/119854807

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#244 (comment)

@bors
Copy link
Contributor

bors commented Mar 31, 2016

⌛ Testing commit 5399c89 with merge dfc1ab5...

bors added a commit that referenced this pull request Mar 31, 2016
@bors
Auto merge of #244 - mrhota:basic_locale, r=alexcrichton
dfc1ab5 
Add lconv type, and locale support for UNIX

We have lconv struct, setlocale(), and localeconv(). Constants live
under notbsd for now.
@bors
Copy link
Contributor

bors commented Mar 31, 2016

☀️ Test successful - status-appveyor, travis

@bors bors merged commit 5399c89 into rust-lang:master Mar 31, 2016
@mrhota mrhota deleted the basic_locale branch March 31, 2016 21:36
danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
@gwenn @alexcrichton
sse2: implements last remaining intrinsics (rust-lang#244)
2c4d880 
* sse2: __m64 related intrinsics

_mm_add_si64
_mm_mul_su32
_mm_sub_si64
_mm_cvtpi32_pd
_mm_set_epi64
_mm_set1_epi64
_mm_setr_epi64

* sse2: _mm_load_sd, _mm_loadh_pd, _mm_loadl_pd

* sse2: _mm_store_sd, _mm_storeh_pd, _mm_storel_pd

* sse2: _mm_shuffle_pd, _mm_move_sd

* sse2: _mm_cast*

_mm_castpd_ps
_mm_castpd_si128
_mm_castps_pd
_mm_castps_si128
_mm_castsi128_pd
_mm_castsi128_ps

* sse2: add some tests

* Try to fix AppVeyor build

* sse2: add more tests

* sse2: fix assert_instr for _mm_shuffle_pd

* Try to fix Travis build

* sse2: try to fix AppVeyor build

* sse2: try to fix AppVeyor build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichton alexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrhota @rust-highfive @alexcrichton @bors