-
Notifications
You must be signed in to change notification settings - Fork 1.2k
musl: Fix CI for testing with version 1.2.3+ #4775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5aa08b to
c2f5374
Compare
87e2f36 to
0c6d2be
Compare
2215a64 to
c8f5200
Compare
This was being set as part of CI but not forwarded to the jobs. Start passing it now.
It appeared that tests with the constants here were passing in CI with new versions of musl before, but that was only because the correct config wasn't being set. Go back to our original configuration (with some cleanup) to resolve this. Fixes: dd44cb6 ("test: linux: Unskip types and constants that are now available")
The issue building rustix that we hit with loongarch is now being hit with ppc64le.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
This was being set as part of CI but not forwarded to the jobs. Start passing it now. (backport <rust-lang#4775>) (cherry picked from commit ab130bf)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
It appeared that tests with the constants here were passing in CI with new versions of musl before, but that was only because the correct config wasn't being set. Go back to our original configuration (with some cleanup) to resolve this. Fixes: dd44cb6 ("test: linux: Unskip types and constants that are now available") (backport <rust-lang#4775>) (cherry picked from commit 075c118)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
This was being set as part of CI but not forwarded to the jobs. Start passing it now. (backport <rust-lang#4775>) (cherry picked from commit ab130bf)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
It appeared that tests with the constants here were passing in CI with new versions of musl before, but that was only because the correct config wasn't being set. Go back to our original configuration (with some cleanup) to resolve this. Fixes: dd44cb6 ("test: linux: Unskip types and constants that are now available") (backport <rust-lang#4775>) (cherry picked from commit 075c118)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
It appeared that tests with the constants here were passing in CI with new versions of musl before, but that was only because the correct config wasn't being set. Go back to our original configuration (with some cleanup) to resolve this. Fixes: dd44cb6 ("test: linux: Unskip types and constants that are now available") (backport <#4775>) (cherry picked from commit 075c118)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-CI
Area: CI-related items
ctest
Issues relating to the ctest crate
stable-applied
This PR has been cherry-picked to libc's stable release branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are in the commit messages.