CI updates #4776
Merged
CI updates #4776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-CI
This seems to be enabled by default on aarch64. We get a number of
errors like:
C:\a\libc\libc\target\aarch64-pc-windows-msvc\debug\build\libc-test-57e9ef381db637c1\out\ctest_output.c(2190) : error C2220: the following warning is treated as an error
C:\a\libc\libc\target\aarch64-pc-windows-msvc\debug\build\libc-test-57e9ef381db637c1\out\ctest_output.c(2190) : warning C4746: volatile access of '<expression>' is subject to /volatile:<iso|ms> setting; consider using __iso_volatile_load/store intrinsic functions
Our volatile use in tests isn't contested so we can safely ignore it.
Link: https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-c4746?view=msvc-170
Default jobs to ubuntu-24.04 but allow for overrides, and decide whether or not to run in Docker based on the target OS being Linux (rather than needing to specify).
aarch64-windows and aarch64-linux are now both tier 1, so promote them in CI.
There isn't really any reason to use both `include` and the default matrix with `target` separately. This requires adding an artifact tag to the musl jobs. Additionally, flatten some bulky env options and prepare the Tier 2 VM targets to have more operating systems.
We have gained quite a few tier 2 jobs. Increase max-parallel so they don't take quite as long.
We no longer use the flaky qemu-system runner, so there shouldn't be any need to keep the retry.
tgross35
force-pushed
the
ci-updates-1
branch
from
fb876b1 to
4e0bfb3
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tgross35
added
the
stable-nominated
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
(backport <rust-lang#4776>) (cherry picked from commit 1b84fd8) [ `cargo update` run after the cherry pick - Trevor ]
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
Default jobs to ubuntu-24.04 but allow for overrides, and decide whether or not to run in Docker based on the target OS being Linux (rather than needing to specify). (backport <rust-lang#4776>) (cherry picked from commit c239dce)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
(backport <rust-lang#4776>) (cherry picked from commit 49c300a)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
aarch64-windows and aarch64-linux are now both tier 1, so promote them in CI. (backport <rust-lang#4776>) (cherry picked from commit 3655bfd)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
There isn't really any reason to use both `include` and the default matrix with `target` separately. This requires adding an artifact tag to the musl jobs. Additionally, flatten some bulky env options and prepare the Tier 2 VM targets to have more operating systems. (backport <rust-lang#4776>) (cherry picked from commit 8b300eb)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
We have gained quite a few tier 2 jobs. Increase max-parallel so they don't take quite as long. (backport <rust-lang#4776>) (cherry picked from commit e3cbac6)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
We no longer use the flaky qemu-system runner, so there shouldn't be any need to keep the retry. (backport <rust-lang#4776>) (cherry picked from commit bad4627)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
(backport <rust-lang#4776>) (cherry picked from commit 1b84fd8) [ `cargo update` run after the cherry pick - Trevor ]
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
Default jobs to ubuntu-24.04 but allow for overrides, and decide whether or not to run in Docker based on the target OS being Linux (rather than needing to specify). (backport <rust-lang#4776>) (cherry picked from commit c239dce)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
(backport <rust-lang#4776>) (cherry picked from commit 49c300a)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
aarch64-windows and aarch64-linux are now both tier 1, so promote them in CI. (backport <rust-lang#4776>) (cherry picked from commit 3655bfd)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
There isn't really any reason to use both `include` and the default matrix with `target` separately. This requires adding an artifact tag to the musl jobs. Additionally, flatten some bulky env options and prepare the Tier 2 VM targets to have more operating systems. (backport <rust-lang#4776>) (cherry picked from commit 8b300eb)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
We have gained quite a few tier 2 jobs. Increase max-parallel so they don't take quite as long. (backport <rust-lang#4776>) (cherry picked from commit e3cbac6)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
We no longer use the flaky qemu-system runner, so there shouldn't be any need to keep the retry. (backport <rust-lang#4776>) (cherry picked from commit bad4627)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
There isn't really any reason to use both `include` and the default matrix with `target` separately. This requires adding an artifact tag to the musl jobs. Additionally, flatten some bulky env options and prepare the Tier 2 VM targets to have more operating systems. (backport <#4776>) (cherry picked from commit 8b300eb)
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are in the commit messages.