Skip to content

ci: Update targets in verify-build #4780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 26, 2025
Merged

ci: Update targets in verify-build #4780

merged 6 commits into from
Oct 26, 2025

Conversation

@tgross35
Copy link
Contributor

@tgross35 tgross35 commented Oct 26, 2025 •
edited
Loading

Update the target list, switch to single-host build checks, and split the nightly build verification job into two.

More details are in the commit messages.

@rustbot rustbot added A-CI Area: CI-related items S-waiting-on-review labels Oct 26, 2025
@tgross35 tgross35 force-pushed the verify-build-updates-2 branch 8 times, most recently from fc54ea2 to 4da3ab1 Compare October 26, 2025 08:48
@tgross35 tgross35 force-pushed the verify-build-updates-2 branch 2 times, most recently from 88ba141 to 254586d Compare October 26, 2025 09:14
@tgross35 tgross35 enabled auto-merge October 26, 2025 09:20
@tgross35
ci: Update targets in verify-build
d374190 
Do a few things:

* Update the list to reflect current target tiers.
* Add some missing T2 targets (includes ohos and gnullvm).
* Remove unneeded `dist = False` and minimum toolchain config.
* Delete some `-none-` targets, which don't make use of libc.
* Add a check for duplicates.
* Re-group and sort the lists.
@tgross35
ci: Always run verify-build on Linux
484637c 
Most of the targets are cross compiled anyway, and there isn't any
advantage to running on native platforms. Start running everything on
Linux which is the fastest and cheapest runner.

As part of this, introduce a way to run only half of the target list
from a single invocation. This is used to split the nightly job in two,
each now only taking about as long as the stable job.
@tgross35
ci: Print elapsed time as part of verify-build
db92b91
@tgross35
ci: Launch create-artifacts.py with python
bf6078e 
We have occasional CI failures on Windows where the environment
variables don't get set so the artifact upload fails. Looking at the
logs, it doesn't even appear the create-artifact job ran (but there are
no errors). The Windows runners sometimes have trouble launching python
scripts via `./`, so switch to using the python3 executable in hopes
that this helps.
@tgross35
aix: Resolve function comparison and unnecessary_transmutes warnings
6bb706b
@tgross35 tgross35 force-pushed the verify-build-updates-2 branch from 254586d to 6bb706b Compare October 26, 2025 09:33
@rustbot
Copy link
Collaborator

rustbot commented Oct 26, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@tgross35 tgross35 force-pushed the verify-build-updates-2 branch from 67ad590 to 1789484 Compare October 26, 2025 09:36
@tgross35 tgross35 added this pull request to the merge queue Oct 26, 2025
Merged via the queue into rust-lang:main with commit a53f4bc Oct 26, 2025
55 checks passed
@tgross35 tgross35 deleted the verify-build-updates-2 branch October 26, 2025 10:21
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 3, 2025
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 4, 2025
@tgross35
ci: Update targets in verify-build
bcd879e 
Do a few things:

* Update the list to reflect current target tiers.
* Add some missing T2 targets (includes ohos and gnullvm).
* Remove unneeded `dist = False` and minimum toolchain config.
* Delete some `-none-` targets, which don't make use of libc.
* Add a check for duplicates.
* Re-group and sort the lists.

(backport <rust-lang#4780>)
(cherry picked from commit 24d0049)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 4, 2025
@tgross35
ci: Always run verify-build on Linux
f402964 
Most of the targets are cross compiled anyway, and there isn't any
advantage to running on native platforms. Start running everything on
Linux which is the fastest and cheapest runner.

As part of this, introduce a way to run only half of the target list
from a single invocation. This is used to split the nightly job in two,
each now only taking about as long as the stable job.

(backport <rust-lang#4780>)
(cherry picked from commit 56b916d)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 4, 2025
@tgross35
ci: Print elapsed time as part of verify-build
3f632e5 
(backport <rust-lang#4780>)
(cherry picked from commit 5e95452)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 4, 2025
@tgross35
ci: Launch create-artifacts.py with python
c9b73c3 
We have occasional CI failures on Windows where the environment
variables don't get set so the artifact upload fails. Looking at the
logs, it doesn't even appear the create-artifact job ran (but there are
no errors). The Windows runners sometimes have trouble launching python
scripts via `./`, so switch to using the python3 executable in hopes
that this helps.

(backport <rust-lang#4780>)
(cherry picked from commit 962b985)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 4, 2025
@tgross35
aix: Resolve function comparison and unnecessary_transmutes warnings
a4c0c65 
(backport <rust-lang#4780>)
(cherry picked from commit c819173)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 4, 2025
@tgross35
ci: For no-dist targets, do a check rather than a full build
1a83707 
(backport <rust-lang#4780>)
(cherry picked from commit a53f4bc)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 4, 2025
@tgross35
ci: Update targets in verify-build
5df6fdf 
Do a few things:

* Update the list to reflect current target tiers.
* Add some missing T2 targets (includes ohos and gnullvm).
* Remove unneeded `dist = False` and minimum toolchain config.
* Delete some `-none-` targets, which don't make use of libc.
* Add a check for duplicates.
* Re-group and sort the lists.

(backport <rust-lang#4780>)
(cherry picked from commit 24d0049)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 4, 2025
@tgross35
ci: Always run verify-build on Linux
5cff45f 
Most of the targets are cross compiled anyway, and there isn't any
advantage to running on native platforms. Start running everything on
Linux which is the fastest and cheapest runner.

As part of this, introduce a way to run only half of the target list
from a single invocation. This is used to split the nightly job in two,
each now only taking about as long as the stable job.

(backport <rust-lang#4780>)
(cherry picked from commit 56b916d)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 4, 2025
@tgross35
ci: Print elapsed time as part of verify-build
6c3d7d2 
(backport <rust-lang#4780>)
(cherry picked from commit 5e95452)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 4, 2025
@tgross35
ci: Launch create-artifacts.py with python
4b11b92 
We have occasional CI failures on Windows where the environment
variables don't get set so the artifact upload fails. Looking at the
logs, it doesn't even appear the create-artifact job ran (but there are
no errors). The Windows runners sometimes have trouble launching python
scripts via `./`, so switch to using the python3 executable in hopes
that this helps.

(backport <rust-lang#4780>)
(cherry picked from commit 962b985)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 4, 2025
@tgross35
aix: Resolve function comparison and unnecessary_transmutes warnings
bfaae4f 
(backport <rust-lang#4780>)
(cherry picked from commit c819173)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 4, 2025
@tgross35
ci: For no-dist targets, do a check rather than a full build
d16571a 
(backport <rust-lang#4780>)
(cherry picked from commit a53f4bc)
@tgross35 tgross35 mentioned this pull request Nov 4, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
@tgross35
ci: Update targets in verify-build
0f4f2a9 
Do a few things:

* Update the list to reflect current target tiers.
* Add some missing T2 targets (includes ohos and gnullvm).
* Remove unneeded `dist = False` and minimum toolchain config.
* Delete some `-none-` targets, which don't make use of libc.
* Add a check for duplicates.
* Re-group and sort the lists.

(backport <#4780>)
(cherry picked from commit 24d0049)
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
@tgross35
ci: Always run verify-build on Linux
c068f61 
Most of the targets are cross compiled anyway, and there isn't any
advantage to running on native platforms. Start running everything on
Linux which is the fastest and cheapest runner.

As part of this, introduce a way to run only half of the target list
from a single invocation. This is used to split the nightly job in two,
each now only taking about as long as the stable job.

(backport <#4780>)
(cherry picked from commit 56b916d)
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
@tgross35
ci: Print elapsed time as part of verify-build
0264335 
(backport <#4780>)
(cherry picked from commit 5e95452)
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
@tgross35
ci: Launch create-artifacts.py with python
6eac4e5 
We have occasional CI failures on Windows where the environment
variables don't get set so the artifact upload fails. Looking at the
logs, it doesn't even appear the create-artifact job ran (but there are
no errors). The Windows runners sometimes have trouble launching python
scripts via `./`, so switch to using the python3 executable in hopes
that this helps.

(backport <#4780>)
(cherry picked from commit 962b985)
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
@tgross35
aix: Resolve function comparison and unnecessary_transmutes warnings
8948e7a 
(backport <#4780>)
(cherry picked from commit c819173)
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
@tgross35
ci: For no-dist targets, do a check rather than a full build
0ebb204 
(backport <#4780>)
(cherry picked from commit a53f4bc)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-CI Area: CI-related items O-powerpc O-unix stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tgross35 @rustbot