macros: Allow s! and s_no_extra_traits! to take private items
#4783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally we need to define structs that keep the expected set of traits but aren't crate-public. Add support to the macros to do this.
Contributor
Author
|
@rustbot label +stable-nominated |
rustbot
added
the
stable-nominated
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
Occasionally we need to define structs that keep the expected set of traits but aren't crate-public. Add support to the macros to do this. (backport <rust-lang#4783>) (cherry picked from commit cdcc466)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
Occasionally we need to define structs that keep the expected set of traits but aren't crate-public. Add support to the macros to do this. (backport <rust-lang#4783>) (cherry picked from commit cdcc466)
Merged
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally we need to define structs that keep the expected set of traits but aren't crate-public. Add support to the macros to do this.