Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebAssembly] Restore defaults for stores per memop #24

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@alexcrichton
Copy link
Member

commented Oct 2, 2019

This is a backport from the master branch of LLVM to address WebAssembly/bulk-memory-operations#111 and https://bugzilla.mozilla.org/show_bug.cgi?id=1570112.

Summary:
Large slowdowns were observed in Rust due to many small, constant
sized copies in conjunction with poorly-optimized memory.copy
implementations. Since memory.copy cannot be expected to be inlined
efficiently by engines at this time, stop using it for the smallest
copies. We continue to lower all memcpy intrinsics to memory.copy,
though.

Reviewers: aheejin, alexcrichton

Subscribers: dschuff, sbc100, jgravelle-google, hiraditya, JDevlieghere, sunfish, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D67639

llvm-svn: 372275
@alexcrichton

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

@nikic nikic merged commit 8473db5 into rust-lang:rustc/9.0-2019-09-19 Oct 2, 2019
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Oct 2, 2019
Bring in rust-lang/llvm-project#24 which brings in some wasm
improvements related to the bulk-memory proposal
@alexcrichton alexcrichton deleted the alexcrichton:wasm-fast branch Oct 2, 2019
@alexcrichton

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

I've posted rust-lang/rust#65002 to update the rustc side of things

Centril added a commit to Centril/rust that referenced this pull request Oct 3, 2019
Update llvm-project submodule

Bring in rust-lang/llvm-project#24 which brings in some wasm
improvements related to the bulk-memory proposal
choller added a commit to choller/rust that referenced this pull request Oct 17, 2019
Bring in rust-lang/llvm-project#24 which brings in some wasm
improvements related to the bulk-memory proposal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.