Generated HTML has CRLF line endings, on a Mac

[zackw]

The HTML generated by mdbook has CRLF line endings. The browser doesn't care, and if I were on Windows it would be the Right Thing, but I'm on a Mac and it makes it annoying to look at the HTML in e.g. the stock vi. Can we please have platform-appropriate line endings?

[steveklabnik]

Sure.

[azerupi]

I'm not sure how that happend, I never use windows and I can't imagine myself writing code that would add CRLF line endings. I would have to check where those come from, maybe someone sneaked it in with a PR or it comes from a dependency.

[steveklabnik]

Yeah, I found the idea confusing as well, but we should figure it out.

[ollie27]

Looks like this is a problem with the 0.0.18 version published to crates.io. The source files have CRLF line endings and this is a problem because index.hbs has CRLF meaning the generated HTML gets a mixture of CRLF and LF line endings.

[azerupi]

Aah I see, thanks for finding the source of the problem!

[steveklabnik]

Interesting, this is probably my fault then. I should submit a .gitattributes to make sure windows users don't accidentally introduce this...

[steveklabnik]

I submitted https://github.com/azerupi/mdBook/pull/236, but I can't actually find a CR in index.hbs, maybe it was fixed in the meantime? @zackw if you use the latest master of mdbook, do you still see this?

[ollie27]

It's only in the version published to crates.io that's broken. I'm guessing you published from Windows and had autocrlf enabled in git. I suggest disabling autocrlf as it just breaks things.