Skip to content

Conversation

@steveklabnik
Copy link
Contributor

This also brings us to parity with rustdoc regarding attributes in
general; while this PR was focused on enabling nightly, that was a
happy accident.

Fixes #241

Check it out:

mdbook

This is after clicking "run" on each. Top goes to stable, bottom to nightly.

This also brings us to parity with rustdoc regarding attributes in
general; while this PR was focused on enabling nightly, that was a
happy accident.
@steveklabnik steveklabnik requested a review from azerupi March 31, 2017 21:07
@azerupi
Copy link
Contributor

azerupi commented Apr 14, 2017

This means that #![... can only occur at the top, right?
Otherwise it looks good, you may merge it :)

@steveklabnik
Copy link
Contributor Author

This means that #![... can only occur at the top, right?

Yeah, it will put them up at the top. This is exactly how it's worked in rustdoc for a long time, so even though it's not perfect, seems fine 😄

@steveklabnik steveklabnik merged commit 9cb2320 into rust-lang:master Apr 14, 2017
@steveklabnik steveklabnik deleted the gh241 branch April 14, 2017 19:19
@steveklabnik
Copy link
Contributor Author

AppVeyor was spurious, so I merged anyway. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants