Nanosleep #1536
Merged
Nanosleep #1536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Sep 7, 2020
RalfJung
reviewed
Sep 7, 2020
RalfJung
reviewed
Sep 7, 2020
RalfJung
reviewed
Sep 7, 2020
RalfJung
reviewed
Sep 7, 2020
RalfJung
reviewed
Sep 7, 2020
RalfJung
reviewed
Sep 7, 2020
Contributor
Author
|
OK, made the changes. I like the |
RalfJung
reviewed
Sep 7, 2020
Member
|
Awesome, thanks a lot for the PR! |
Contributor
|
📌 Commit b06f0d1 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a shim for
libc::nanosleep, (available under -Zmiri-disable-isolation only) which backsthread::sleepon Linux and macOS. I started off by extracting thetimespecparsing from thepthread_cond_timedwaitshim into a helper method, and adding checks for invalid values. The second commit adds the new shim and a small test. The shim blocks the current thread, and registers a timeout callback to unblock the thread again, using the same method aspthread_cond_timedwaitdoes.