Skip to content

Conversation

@RalfJung
Copy link
Member

I have zero experience with Travis, so I will see whether my script makes any sense when Travis checks this PR. Also, I don't think this entire multi-platform-testing stuff will work out here and I am not sure what is the best way to fix that.

Someone should look at the situation with these two environment variables (RUST_SYSROOT vs. SYSROOT).

@RalfJung RalfJung force-pushed the xargo-test branch 4 times, most recently from fd22a9b to 1732b3d Compare May 31, 2017 20:31
@RalfJung
Copy link
Member Author

Well, that actually went better than expected. I had to make the stack overflow test less precise, because the exact point where the stack overflow happens depends on how many functions are called "between" the 'start' lang item and main, but other than that, things seem to Work (TM) now.

Maybe the compiled xargo should be cached somehow?

@oli-obk
Copy link
Contributor

oli-obk commented May 31, 2017

We could cache it, but the next nightly will break the cache

@oli-obk
Copy link
Contributor

oli-obk commented May 31, 2017

I think this only runs for the host now. Fine by me. Xargo can't generate libstd for other targets anyway.

@oli-obk oli-obk merged commit b946351 into rust-lang:master May 31, 2017
@RalfJung
Copy link
Member Author

Yeah, that's true. I tried using xargo build --target ..., but that failed. I assume it's because there is some C code being compiled here (in jemalloc)?

@oli-obk
Copy link
Contributor

oli-obk commented May 31, 2017

Nevermind. It runs the old Test suite for all targets and the Xargo one for full mir

@RalfJung RalfJung deleted the xargo-test branch May 31, 2017 21:25
@RalfJung
Copy link
Member Author

Glad you're fine with that :)

@oli-obk
Copy link
Contributor

oli-obk commented May 31, 2017

Idk what the issue is. Just that the xargo docs state the fact that libstd can only be generated for the host

@RalfJung
Copy link
Member Author

They do? Must have missed that part.^^

@oli-obk
Copy link
Contributor

oli-obk commented May 31, 2017

They did, but I got it the wrong way around. You couldn't build a sysroot for the host. But you can now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants