Skip to content

Conversation

@folkertdev
Copy link
Contributor

One more for the zlib-rs adler32 implementation.

The code for sse2, avx2 and avx512 is basically identical, so I centralized the implementation.

@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2025

Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two.
Please remember to not force-push to the PR branch except when you need to rebase due to a conflict or when the reviewer asks you for it.

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Nov 14, 2025
@folkertdev folkertdev changed the title add an avx512 psad shim add an avx512 psadbw shim Nov 14, 2025
@folkertdev
Copy link
Contributor Author

I added a more interesting test than what stdarch has, this new test was tested on real hardware.

Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RalfJung
Copy link
Member

Nice catch with the deduplication. :)

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Nov 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 15, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@folkertdev
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Nov 15, 2025
@RalfJung
Copy link
Member

This looks great, thanks! Please squash the commits using ./miri squash. Then write @rustbot ready after you force-pushed the squashed PR.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Nov 15, 2025
also combine the sse2 and avx2 version into one generic function for all 3
@folkertdev
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Nov 15, 2025
@RalfJung RalfJung added this pull request to the merge queue Nov 15, 2025
Merged via the queue into rust-lang:master with commit 19ebb84 Nov 15, 2025
13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Waiting for a review to complete label Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants