-
Notifications
You must be signed in to change notification settings - Fork 408
add an avx512 psadbw shim
#4686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
|
I added a more interesting test than what stdarch has, this new test was tested on real hardware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Nice catch with the deduplication. :) @rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
|
@rustbot ready |
|
This looks great, thanks! Please squash the commits using @rustbot author |
also combine the sse2 and avx2 version into one generic function for all 3
18602b2 to
3bb41b2
Compare
|
@rustbot ready |
One more for the zlib-rs adler32 implementation.
The code for sse2, avx2 and avx512 is basically identical, so I centralized the implementation.