Skip to content

Conversation

@folkertdev
Copy link
Contributor

Turns out we need a couple more, but the implementation can be shared with existing versions.

@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2025

Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two.
Please remember to not force-push to the PR branch except when you need to rebase due to a conflict or when the reviewer asks you for it.

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Nov 17, 2025
Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I can't say I can make sense of this maddubs test (it looks like lots of random numbers), but the code is the same as before so 🤷

I assume you ran the tests on real hardware?

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Nov 17, 2025
@folkertdev
Copy link
Contributor Author

I can't say I can make sense of this maddubs test (it looks like lots of random numbers), but the code is the same as before so 🤷

The numbers attempt to exercise some of the interesting behavior with the saturation. But yeah it's tough.

I assume you ran the tests on real hardware?

Yes

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Nov 17, 2025
@folkertdev
Copy link
Contributor Author

Oh btw has your opinion on force pushes changed now that we have the improved diffs? Or should I just squash all changes into one commit anyway?

@RalfJung
Copy link
Member

Yeah I guess we can be more relaxed about force-pushes now, though that does require some discipline to always submit a comment with the review so that we get the diff links.

This one is ready to have the fixup commit squashed in whatever way you think makes sense (the one-commit ./miri squash automation is just there to make it easier for people). Thanks!

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Nov 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@folkertdev
Copy link
Contributor Author

I absorbed the changes into the earlier commits

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Nov 17, 2025
@RalfJung RalfJung dismissed their stale review November 17, 2025 21:38

resolved

@RalfJung RalfJung enabled auto-merge November 17, 2025 21:38
@RalfJung RalfJung added this pull request to the merge queue Nov 17, 2025
Merged via the queue into rust-lang:master with commit 2675b8d Nov 17, 2025
13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Waiting for a review to complete label Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants