-
Notifications
You must be signed in to change notification settings - Fork 408
Add avx512 permute and pmaddbw #4705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I can't say I can make sense of this maddubs test (it looks like lots of random numbers), but the code is the same as before so 🤷
I assume you ran the tests on real hardware?
The numbers attempt to exercise some of the interesting behavior with the saturation. But yeah it's tough.
Yes @rustbot ready |
|
Oh btw has your opinion on force pushes changed now that we have the improved diffs? Or should I just squash all changes into one commit anyway? |
|
Yeah I guess we can be more relaxed about force-pushes now, though that does require some discipline to always submit a comment with the review so that we get the diff links. This one is ready to have the fixup commit squashed in whatever way you think makes sense (the one-commit @rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
52f3790 to
51f7643
Compare
|
I absorbed the changes into the earlier commits @rustbot ready |
Turns out we need a couple more, but the implementation can be shared with existing versions.