refactor: clean up unused LLVM SIMD

[hulxv]

Close #4659

[rustbot]

Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two.
Please remember to not force-push to the PR branch except when you need to rebase due to a conflict or when the reviewer asks you for it.

[folkertdev]

I'm not sure everything has been synchronized all the way, based on the CI log where it complains that there is no implementation for maskload. So miri may need to be synchronized with upstream rust-lang/rust first?

Did the tests pass for you locally?

[RalfJung]

Yeah, this only makes sense once the stdarch changes are synced to rustc (I don't know if that happened), and then rustc is synced to Miri.

@hulxv it's generally a good idea to ask before starting to work on an issue. :)

And indeed, please run tests locally. CI exists to catch oversights that happen, but it is not a good replacement for local testing: the feedback cycle is just way too slow for that, and it is too noisy (project members get emails for PR updates).

[folkertdev]

Yeah, this only makes sense once the stdarch changes are synced to rustc (I don't know if that happened)

This did happen in rust-lang/rust#149118

[RalfJung]

Yeah, this only makes sense once the stdarch changes are synced to rustc (I don't know if that happened)

This did happen in rust-lang/rust#149118

Ah, that's shortly after the most recent sync (yesterday morning). I can kick off a manual sync to unblock this PR.

[RalfJung]

Uh, no, the fix for failing tests is not to remove the tests.

[hulxv]

@hulxv it's generally a good idea to ask before starting to work on an issue. :)

And indeed, please run tests locally. CI exists to catch oversights that happen, but it is not a good replacement for local testing: the feedback cycle is just way too slow for that, and it is too noisy (project members get emails for PR updates).

Oh, I am really for that. I didn't know that would annoy you. I think the CI will work now. I tested it locally. Can you please explain the current situation? What's this sync problem?

[hulxv]

Uh, no, the fix for failing tests is not to remove the tests.

Aren't these intrinsics removed? how can I fix them then?

[RalfJung]

Can you please explain the current situation? What's this sync problem?

You will have to wait until #4716 lands, and then rebase your branch. Then CI should pass.

The failing tests indicate that in the version used for testing, the intrinsics are still needed. The test is important to keep, it ensures that Miri can run all these stdarch functions.

[hulxv]

So I need to revert d250793 right? Is there anything else I need to do?

[RalfJung]

You should remove that commit, and rebase your PR once #4716 lands.

[hulxv]

Is it good now?

[RalfJung]

This looks great, thanks! Please squash the commits. You can squash manually if there are multiple independent commits you want to preserve, or use ./miri squash (make sure to pick a suitable commit message). Then write @rustbot ready after you force-pushed the squashed PR.

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[hulxv]

@rustbot ready