Skip to content

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Nov 28, 2025

This way we don't need a special case in MiriBeRustCompilerCalls.

@rustbot
Copy link
Collaborator

rustbot commented Nov 28, 2025

Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two.
Please remember to not force-push to the PR branch except when you need to rebase due to a conflict or when the reviewer asks you for it.

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Nov 28, 2025
Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I like the general approach. We can also update a bunch of comments and names then, I think.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Nov 28, 2025
@RalfJung
Copy link
Member

That's annoying that we can't use return to make it clear that the call won't return... is there some other nice way to make that syntactically obvious?

@bjorn3
Copy link
Member Author

bjorn3 commented Dec 1, 2025

match rustc_driver::main() {} works.

@bjorn3
Copy link
Member Author

bjorn3 commented Dec 1, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Dec 1, 2025
@RalfJung
Copy link
Member

RalfJung commented Dec 1, 2025

LGTM, thanks! r=me after adding the comment and squashing.

This way we don't need a special case in MiriBeRustCompilerCalls.

Co-Authored-By: Ralf Jung <post@ralfj.de>
@RalfJung RalfJung enabled auto-merge December 2, 2025 14:05
@RalfJung RalfJung dismissed their stale review December 2, 2025 14:05

resolved

@RalfJung RalfJung added this pull request to the merge queue Dec 2, 2025
Merged via the queue into rust-lang:master with commit 092a83d Dec 2, 2025
14 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Waiting for a review to complete label Dec 2, 2025
@bjorn3 bjorn3 deleted the simplify_driver branch December 2, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants