Skip to content

Conversation

@RalfJung
Copy link
Member

@apoelstra what do you think?

@apoelstra
Copy link
Contributor

I think this looks great.

I didn't follow the removal of the -Zstart-fn stuff, or understand what it was for, so I'll just pretend it never existed.

@RalfJung RalfJung requested a review from oli-obk October 24, 2018 14:59

with `+nightly` replaced with the appropriate nightly version of Rust.
This uses the very latest Rust version. If you experience any problem, refer to
the `rust-version` file which contains a particular Rust nightly version that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could rename the file to rust-toolchain and rustup would pick it up automatically. Is there any reason we're not doing that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol we just renamed it back from that in the last PR.^^

The reason is that people get really confused when they do cargo install, and then use cargo miri and nothing works because now they have to manually set the nightly to use to exactly match the one miri uses.

Basically, rust-toolchain helps miri developers, but it doesn't help any user that wants to use cargo miri. (It helps for really simple examples that work with cargo run, but you can just as well use the playground for these.) That seems like the wrong tradeoff.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh ok. makes sense.

@oli-obk oli-obk merged commit c02988b into rust-lang:master Oct 24, 2018
@RalfJung RalfJung deleted the readme branch November 8, 2018 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants