Skip to content

Conversation

@aDotInTheVoid
Copy link
Member

I went through the "Initial Integration" and fixed references to the old project name, and cleaned up bits that were confusing:

  • Add link to demo/, to show a complete version
  • Replace references to stable_mir with rustc_public
  • Reference recent nightly toolchain
  • Document need for #![feature(rustc_private)]
  • Invoke run! macro qualified, instead of via #[macro_use]
  • Give type of arguments to run!
  • Don't duplicate list of extern crates

I went through the "Initial Integration" and fixed references to the old
project name, and cleaned up bits that were confusing:

- Add link to `demo/`, to show a complete version
- Replace references to `stable_mir` with `rustc_public`
- Reference recent nightly toolchain
- Document need for `#![feature(rustc_private)]`
- Invoke `run!` macro qualified, instead of via `#[macro_use]`
- Give type of arguments to `run!`
- Don't duplicate list of `extern crate`s
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@celinval celinval merged commit 1788ea1 into rust-lang:main Oct 28, 2025
3 of 4 checks passed
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Dec 1, 2025
I went through the "Initial Integration" and fixed references to the old
project name, and cleaned up bits that were confusing:

- Add link to `demo/`, to show a complete version
- Replace references to `stable_mir` with `rustc_public`
- Reference recent nightly toolchain
- Document need for `#![feature(rustc_private)]`
- Invoke `run!` macro qualified, instead of via `#[macro_use]`
- Give type of arguments to `run!`
- Don't duplicate list of `extern crate`s
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Dec 2, 2025
I went through the "Initial Integration" and fixed references to the old
project name, and cleaned up bits that were confusing:

- Add link to `demo/`, to show a complete version
- Replace references to `stable_mir` with `rustc_public`
- Reference recent nightly toolchain
- Document need for `#![feature(rustc_private)]`
- Invoke `run!` macro qualified, instead of via `#[macro_use]`
- Give type of arguments to `run!`
- Don't duplicate list of `extern crate`s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants