Apply several markup fixes #3878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the unclosed `<a>` tags.
This ensures the code block is part of the list.
This fixes some bare HTML tags by wrapping them in a code span or using html entities.
In mdbook 0.5, it will support definition lists, and unfortunately the way this is written gets interpreted as a definition list. The simple fix is to remove the unneeded newline. See pulldown-cmark/pulldown-cmark#1057
This close tag was missing the slash.
`img` is a void element and does not take an end tag.
I assume this is what is intended. Otherwise the `simp` footnote definition is unused.
In commonmark, markup is not translated inside raw HTML. This makes a few changes to make this process correctly.
ehuss
added
the
not-rfc
Urgau
approved these changes
Nov 8, 2025
| ## Use cases | ||
|
|
||
| ### Poor interaction with overloadable deref and index <a name=overload> | ||
| ### Poor interaction with overloadable deref and index { #overload } |
Member
There was a problem hiding this comment.
I didn't knew this was a syntax, very fancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes several commits to fix various markdown errors in the rfc book. This is in preparation for mdbook 0.5 which is a little more sensitive to markdown errors (mostly generating warnings, or not rendering as expected). This should be compatible with both 0.5 and 0.4.
r? internal-sites
Rendered