-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
A-assistsA-macromacro expansionmacro expansionS-actionableSomeone could pick this issue up and work on it right nowSomeone could pick this issue up and work on it right nowgood first issue
Description
With #10067 we now map tokens down in macros to all their usages and not just the first. IDE functionalities have to be adapted to this change as currently everything expects a 1 to 1 mapping.
In most cases this should be straight forward by just iterating instead of handling a single instance, some require more thought like how hover should deal with this.
This tracks all the things that have to be changed:
- replace
find_node_at_offset_with_descend->find_nodes_at_offset_with_descendin:-
highlight_relatedfeat: Downmap tokens to all token descendants instead of just the first #10067 -
goto_implementationfix: makegoto_implementationmulti-token mapping aware #10108 -
referencesfix: make "find references" multi-token mapping aware #10103 -
renamefix: makerenamemulti-token mapping aware #10645 -
ide_ssr
-
- replace
descend_into_macros->descend_into_macros_manyin:-
call_hierarchyinternal: Improve call_hierarchy and incoming/outgoing_calls #10250 -
expand_macrofix: makeexpand_macromulti-token mapping aware #10641 -
goto_declarationfix: makegoto_declarationmulti-token mapping aware #10639 -
goto_definitionfix: makegoto_definitionmulti-token mapping aware #10252 -
goto_type_definitionfix: makegoto_type_definitionmulti-token mapping aware #10637 -
hoverfix: add multi-token mapping support to hovers #10233 -
runnablesfix: add multi-token mapping support to runnables #10188
-
This list isn't all usages but most of which it would make sense to support this change.
Note in some cases duplicates have to be filtered out as tokens that are emitted multiple times pointing to the same things will multiply outputs.
Metadata
Metadata
Assignees
Labels
A-assistsA-macromacro expansionmacro expansionS-actionableSomeone could pick this issue up and work on it right nowSomeone could pick this issue up and work on it right nowgood first issue