Syntax Error: expected expression

[jyn514]

I get incorrect errors on the following code. I think rust-analyzer might not like directives in the middle of a function call.

fn assert_float(s: &str, n: f64) {}

fn main() {
    assert_float(
        "1.797693134862315708e+308L",
        #[allow(clippy::excessive_precision)]
        1.797_693_134_862_315_730_8e+308,
    );
}

shows up right after +308L",:

Syntax Error: expected expression
Syntax Error: expected SEMI

The errors also show up after e+308,.

[jyn514]

Update: removing the clippy directive makes the errors go away.

[bjorn3]

Does this happen for all attributes in that position or only clippy lint levels?

[jyn514]

All attributes in that position. I tested with #[allow(dead_code)].

[lnicola]

Same as #2781?

[bjorn3]

#2781 is for tuples while this is for call params. They are very similar though.

[edwin0cheng]

Yeah, we didn't handle Attr in arguments list yet :

https://github.com/rust-analyzer/rust-analyzer/blob/86d2af9f7b3f6af2ea9e4eca2584aa501b60aa14/crates/ra_parser/src/grammar/expressions.rs#L538-L554

[jyn514]

I can take a stab at this :) I saw there were instructions in https://github.com/rust-analyzer/rust-analyzer/tree/master/docs/dev, I'll try and make a start today.