New weekly build pegs CPU at 100%, is janky at Enter

[djc]

With today's new weekly build (0.2.143), I'm having a bad experience so far:

This is while hacking on hyper with VS Code on MacOS.

[djc]

The output just showed this, which probably has something to do with it:

thread '<unnamed>' panicked at 'overflow depth reached', <::std::macros::panic macros>:2:4
stack backtrace:
   0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   1: core::fmt::write
   2: std::io::Write::write_fmt
   3: std::panicking::default_hook::{{closure}}
   4: std::panicking::default_hook
   5: std::panicking::rust_panic_with_hook
   6: std::panicking::begin_panic
   7: chalk_solve::recursive::Solver<I>::solve_goal
   8: chalk_solve::recursive::fulfill::Fulfill<I>::prove
   9: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  10: chalk_solve::recursive::Solver<I>::solve_via_implication
  11: chalk_solve::recursive::Solver<I>::solve_goal
  12: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  13: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  14: chalk_solve::recursive::Solver<I>::solve_via_implication
  15: chalk_solve::recursive::Solver<I>::solve_goal
  16: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  17: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  18: chalk_solve::recursive::Solver<I>::solve_via_implication
  19: chalk_solve::recursive::Solver<I>::solve_goal
  20: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  21: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  22: chalk_solve::recursive::Solver<I>::solve_via_implication
  23: chalk_solve::recursive::Solver<I>::solve_goal
  24: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  25: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  26: chalk_solve::recursive::Solver<I>::solve_via_implication
  27: chalk_solve::recursive::Solver<I>::solve_goal
  28: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  29: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  30: chalk_solve::recursive::Solver<I>::solve_via_implication
  31: chalk_solve::recursive::Solver<I>::solve_goal
  32: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  33: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  34: chalk_solve::recursive::Solver<I>::solve_via_implication
  35: chalk_solve::recursive::Solver<I>::solve_goal
  36: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  37: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  38: chalk_solve::recursive::Solver<I>::solve_via_implication
  39: chalk_solve::recursive::Solver<I>::solve_goal
  40: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  41: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  42: chalk_solve::recursive::Solver<I>::solve_via_implication
  43: chalk_solve::recursive::Solver<I>::solve_goal
  44: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  45: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  46: chalk_solve::recursive::Solver<I>::solve_via_implication
  47: chalk_solve::recursive::Solver<I>::solve_goal
  48: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  49: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  50: chalk_solve::recursive::Solver<I>::solve_via_implication
  51: chalk_solve::recursive::Solver<I>::solve_goal
  52: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  53: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  54: chalk_solve::recursive::Solver<I>::solve_via_implication
  55: chalk_solve::recursive::Solver<I>::solve_goal
  56: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  57: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  58: chalk_solve::recursive::Solver<I>::solve_via_implication
  59: chalk_solve::recursive::Solver<I>::solve_goal
  60: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  61: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  62: chalk_solve::recursive::Solver<I>::solve_via_implication
  63: chalk_solve::recursive::Solver<I>::solve_goal
  64: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  65: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  66: chalk_solve::recursive::Solver<I>::solve_via_implication
  67: chalk_solve::recursive::Solver<I>::solve_goal
  68: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  69: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  70: chalk_solve::recursive::Solver<I>::solve_via_implication
  71: chalk_solve::recursive::Solver<I>::solve_goal
  72: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  73: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  74: chalk_solve::recursive::Solver<I>::solve_via_implication
  75: chalk_solve::recursive::Solver<I>::solve_goal
  76: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  77: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  78: chalk_solve::recursive::Solver<I>::solve_via_implication
  79: chalk_solve::recursive::Solver<I>::solve_goal
  80: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  81: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  82: chalk_solve::recursive::Solver<I>::solve_via_implication
  83: chalk_solve::recursive::Solver<I>::solve_goal
  84: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  85: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  86: chalk_solve::recursive::Solver<I>::solve_via_implication
  87: chalk_solve::recursive::Solver<I>::solve_goal
  88: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  89: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  90: chalk_solve::recursive::Solver<I>::solve_via_implication
  91: chalk_solve::recursive::Solver<I>::solve_goal
  92: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  93: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  94: chalk_solve::recursive::Solver<I>::solve_via_implication
  95: chalk_solve::recursive::Solver<I>::solve_goal
  96: chalk_solve::recursive::fulfill::Fulfill<I>::prove
  97: chalk_solve::recursive::fulfill::Fulfill<I>::solve
  98: chalk_solve::recursive::Solver<I>::solve_via_implication
  99: chalk_solve::recursive::Solver<I>::solve_goal
 100: chalk_solve::recursive::fulfill::Fulfill<I>::prove
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

[bjorn3]

I would guess this is #3990.

[bjorn3]

cc @flodiebold

[flodiebold]

Can you run rust-analyzer analysis-stats . in your hyper checkout? Is the problem reproducible with hyper master? It doesn't happen for me, but the version I tested right now already had some performance fixes. Still, the overflow should be reproducible...

Edit: I got the overflow with an older build. I think it's probably fixed by rust-lang/chalk#404. This also improves performance in hyper a lot.

[djc]

FWIW, my branch is djc/hyper@e4de2b6 (not sure how long this commit will live past today).

I'm not sure where the rust-analyzer binary (is it called rust-analyzer-mac like it is in Activity Monitor) lives when I just use the extension from the VS Code marketplace.

[bjorn3]

I think commits referenced by comments stay alive even when they are no longer referenced from a branch or tag.

[djc]

So the upstream issue is fixed -- I suspect there still needs to be a change to fold this into RA.

Is there some threshold of seriousness where a new weekly gets issued, and if so, is that threshold hit by this issue? Are there easy ways of switching between weekly builds and self-built ones?

[flodiebold]

There's nightly, which I think it's pretty easy to switch to on VSCode?

[flodiebold]

Actually the hyper overflow is still sometimes reproducible with the performance fix.

[shirshak55]

still rust analyzer is showing high usage. its not that high but still higher than normal. I am using nightly channel.

[Bert-Proesmans]

Same here while working on an Amethyst playground project. The symptoms are pretty serious: the plugin locks up my editor and RA keeps allocating RAM until I shut it down. I'm on Windows using the latest versions of RA and VSCode stable as of this week.

Reading from the comments it seems a possible fix is already found. In any case, this is the output I receive from RA analysis stats:

Database loaded, 382 roots, 1.2859903s
Crates in this dir: 1
Total modules found: 8
Total declarations: 50
Total functions: 17
Item Collection: 22.128117s, 0b allocated 0b resident
Total expressions: 763
Expressions of unknown type: 27 (3%)
Expressions of partially unknown type: 14 (1%)
Type mismatches: 2
Inference: 20.7860639s, 0b allocated 0b resident
Total: 42.9145883s, 0b allocated 0b resident