Adding imports / other fixes not advertised as "quickfix"?

[antifuchs]

I recently upgraded lsp-mode in emacs, and it appears there's a new setting, lsp-ui-sideline-actions-kind-regex, which defaults to showing only quickfix and refactor-type assists. There are several bug-removal assists that rust-analyzer offers that present as the "" type, including adding missing imports. The lsp-mode issue&work-around for this is emacs-lsp/lsp-ui#455

My intuition is that rust-analyzer is not sending the correct type for those assists & that they should be quickfixes; do you agree?

[bjorn3]

#5115 (comment)

The suggestion is marked as MaybeIncorrect: https://github.com/rust-lang/rust/blob/master/src/librustc_typeck/check/method/suggest.rs#L870

[kjeremy]

We don't categorize all assists yet but it will be in soon: #5116

[kjeremy]

@antifuchs assists are now categorized.

[antifuchs]

Great news! I'll try this asap & report back (:

[matklad]

optimistically closing

[antifuchs]

Belated confirmation that the quick fixes I have tried all seem to be properly classified. Thanks!