Can't get the version information

[azzamsa]

Hi.

After a change request (#7854) and a change, #7984 merged.
The output of rust-analyzer should be:

❯ ./rust-analyzer-2021-03-15 --version
rust-analyzer 2021-03-15


❯ ./rust-analyzer-nightly --version
rust-analyzer-2021-03-15-gc0a2b4e

But, after downloading the c0a2b4e nightly release and the 2021-03-15 latest release. This is what I get:.

❯ ./rust-analyzer-2021-03-15 --version
rust-analyzer


❯ ./rust-analyzer-nightly --version
rust-analyzer

Am I missing something?

Thanks for rust-analyzer.

[lnicola]

Looks like #8049 didn't help here.

[lnicola]

If I clone the repository using git clone --depth 200 https://github.com/rust-analyzer/rust-analyzer and build it with cargo xtask dist, the resulting binary shows the version:

rust-analyzer nightly-4-g5ac0290f

So I'm not sure what's up.

[SomeoneToIgnore]

Can confirm the same: locally built version does show the correct string, the nightly version does not.
Could it be that the CI has no .git directory when building? (I've experienced such behavior with TeamCity before)

[lnicola]

Maybe, see #8121 (comment). But the action does have an option for the fetch depth, so why would that exist if there's no .git?

I guess we can revert #7984.

[SomeoneToIgnore]

I like the information improvement in general, so maybe we can leave it and fall back to less descriptive version string instead?
This also leaves an opportunity to debug and fix the CI issue for somebody.

[flodiebold]

It looks like the action does the fetch with --no-tags. We could probably fetch tags ourselves, or maybe there's an option to disable that.

[flodiebold]

Apparently setting fetch-depth to 0 will make it fetch tags as well. It somewhat makes sense, since git fetch --tags would also fetch the whole repository. Do we need the shallow checkout for the release action?