Skip to content

internal: don't shut up the compiler when it says the code's buggy #10080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2021
Merged

internal: don't shut up the compiler when it says the code's buggy #10080

merged 1 commit into from
Aug 30, 2021
+96 −57

Conversation

@matklad
Copy link
Contributor

@matklad matklad commented Aug 30, 2021

bors r+
🤖

bors bot added a commit that referenced this pull request Aug 30, 2021
@bors @matklad
Merge #10080
340af29 
10080: internal: don't shut up the compiler when it says the code's buggy r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@matklad matklad mentioned this pull request Aug 30, 2021
Merged
@matklad
internal: don't shut up the compiler when it says the code's buggy
a833fba 
Wrapping state-modifying functions into a `catch_unwind` is wrong -- to
do retry after failure, you need to have transactional semantics!
@bors
Copy link
Contributor

bors bot commented Aug 30, 2021

Canceled.

@matklad
Copy link
Contributor Author

matklad commented Aug 30, 2021

bors r+

matklad
matklad commented Aug 30, 2021
View reviewed changes
crates/rust-analyzer/src/dispatch.rs
/// (`on` method).
///
/// Some read-only requests are latency sensitive, and are immediately handled
/// on the main loop thread (`on_sync`). These are typically typing-related
Copy link
Contributor Author

@matklad matklad Aug 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Veykril [`RequestDispatcher::on_sync`] doesn't work for me. Is it our bug, or is this just isn't supported by rustdoc?

Copy link
Member

@bjorn3 bjorn3 Aug 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work I think.

Copy link
Member

@Veykril Veykril Sep 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ye I'm pretty sure that should work with rustdoc. Odd that we don't resolve this 🤔

Copy link
Member

@Veykril Veykril Sep 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right this is #9694

@bors
Copy link
Contributor

bors bot commented Aug 30, 2021

Build succeeded:

@bors bors bot merged commit ceecf85 into rust-lang:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Veykril Veykril Veykril left review comments

+1 more reviewer

@bjorn3 bjorn3 bjorn3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matklad @Veykril @bjorn3