Skip to content

Conversation

@lf-
Copy link
Contributor

@lf- lf- commented Sep 4, 2021

bors r+
🤖

@lf-
Copy link
Contributor Author

lf- commented Sep 4, 2021

damn, my git-sin script had a bug in it 🤣
bors r+

bors bot added a commit that referenced this pull request Sep 4, 2021
10145: Update dependency minor versions
 r=lf- a=lf-

bors r+
🤖

Co-authored-by: Jade <software@lfcode.ca>
Cargo.lock Outdated
"xflags",
"xshell",
]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo-update generated them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOps

@lf-
Copy link
Contributor Author

lf- commented Sep 4, 2021

bors r-

@bors
Copy link
Contributor

bors bot commented Sep 4, 2021

Canceled.

@lnicola
Copy link
Member

lnicola commented Sep 4, 2021

bors r-

cargo-update generated them.

Ugh, that's strange. Do you have any local Cargo.toml changes?

And in the meanwhile, can you pin libc to 0.2.99 in crates/rust-analyzer/Cargo.toml (I hope that works)? I wanted to open a PR, but then I saw yours. It's needed because newer versions don't build on FreeBSD.

@lf-
Copy link
Contributor Author

lf- commented Sep 4, 2021

bors r-

cargo-update generated them.

Ugh, that's strange. Do you have any local Cargo.toml changes?

And in the meanwhile, can you pin libc to 0.2.99 in crates/rust-analyzer/Cargo.toml (I hope that works)? I wanted to open a PR, but then I saw yours. It's needed because newer versions don't build on FreeBSD.

Done.

@lnicola
Copy link
Member

lnicola commented Sep 4, 2021

bors r+

@lnicola lnicola changed the title Update dependency minor versions minor: Update dependency minor versions Sep 4, 2021
@bors
Copy link
Contributor

bors bot commented Sep 4, 2021

@bors bors bot merged commit f0f0278 into master Sep 4, 2021
@bors bors bot deleted the update-deps branch September 4, 2021 07:39
@matklad
Copy link
Contributor

matklad commented Sep 4, 2021

FWIW, I've extended my gbors script to give an ooportunity to prep a PR description out of concatenated commit messages: https://github.com/matklad/config/blob/8ccb77cba70ad052ce121c4cfd9a57c8ee39dd93/tool/src/gbors.rs

@lf-
Copy link
Contributor Author

lf- commented Sep 4, 2021

FWIW, I've extended my gbors script to give an ooportunity to prep a PR description out of concatenated commit messages: https://github.com/matklad/config/blob/8ccb77cba70ad052ce121c4cfd9a57c8ee39dd93/tool/src/gbors.rs

Ah yes, so I can own myself harder and faster 🤣

@matklad
Copy link
Contributor

matklad commented Sep 4, 2021

Yeah; julia has known startup latency problems (known as TTFP -- time to first plot), and, after careful benchmarking and taking Amdahl's law into consideration, I came to the conclusion that gbors performance is the main limiting factor for my productivity, hence the Rust rewrite.

@bjorn3
Copy link
Member

bjorn3 commented Sep 4, 2021

Why not make gbors a self-compiling rust script? :) https://github.com/bjorn3/rustc_codegen_cranelift/blob/master/y.rs#L1-L8

@matklad
Copy link
Contributor

matklad commented Sep 4, 2021

That's lovely! I do want to use dependencies though (xshell and anyhow), and I want to have a busy-box style single binary which dispatches based on argv[0].

Also, I wonder why we don't have an RFC for rustc run main.rs? That feels like a feature we should have...

@matklad
Copy link
Contributor

matklad commented Sep 4, 2021

(btw, the stuff is sort-of self-linking at least: https://github.com/matklad/config/blob/7371bb2e043ce37be872e25f0871baacba033747/tool/src/main.rs#L30)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants