Skip to content

Conversation

@theo-lw
Copy link
Contributor

@theo-lw theo-lw commented Sep 10, 2021

Addresses issue #10106.

In-progress - I'm trying to figure out why hover_deref_expr_with_coercion is failing.

@theo-lw theo-lw marked this pull request as draft September 11, 2021 00:17
@theo-lw theo-lw marked this pull request as ready for review September 11, 2021 15:53
@Veykril Veykril self-assigned this Sep 13, 2021
@Veykril
Copy link
Member

Veykril commented Sep 13, 2021

The spacing is off in the test output since you manually edited the typoes there, so the alignment isn't correct for the expects.

@bors
Copy link
Contributor

bors bot commented Sep 14, 2021

✌️ theo-lw can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Veykril Veykril changed the title Show the type of what is being dereferenced in a derf expression. feat: Show the type of what is being dereferenced in a deref expression. Sep 14, 2021
@theo-lw
Copy link
Contributor Author

theo-lw commented Sep 14, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 14, 2021

@bors bors bot merged commit e896def into rust-lang:master Sep 14, 2021
@theo-lw theo-lw deleted the issue-10106 branch September 14, 2021 00:57
@Veykril
Copy link
Member

Veykril commented Sep 14, 2021

Thanks for the contribution!

@lnicola
Copy link
Member

lnicola commented Sep 14, 2021

changelog feat (first contribution) show dereferenced types in hover

@lnicola
Copy link
Member

lnicola commented Sep 20, 2021

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants