Skip to content

Conversation

@gilescope
Copy link
Contributor

cargo check --all-targets compiles cleanly without these dependencies for me.

@lnicola
Copy link
Member

lnicola commented Sep 11, 2021

bors r+

@lnicola lnicola changed the title Reduce deps internal: Remove unused dependencies Sep 11, 2021
Copy link
Contributor

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

tt = { path = "../tt", version = "0.0.0" }
test_utils = { path = "../test_utils", version = "0.0.0" }
vfs = { path = "../vfs", version = "0.0.0" }
stdx = { path = "../stdx", version = "0.0.0" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep stdx -- it' uself to stdx::print_backtrace when debugging without messing with Cargo.tomls.

Though, doesn't really matter.

@bors
Copy link
Contributor

bors bot commented Sep 11, 2021

Already running a review

@bors
Copy link
Contributor

bors bot commented Sep 11, 2021

@bors bors bot merged commit 9aa71cc into rust-lang:master Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants