internal: Add more tests for ide functionality in attributed items #10232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Sep 14, 2021
| cfg: None, | ||
| }, | ||
| ] | ||
| "#]], |
Contributor
There was a problem hiding this comment.
As a meta note, I feel that we over-use expect-debug tests. Here they are OK maybe, but, eg, in hover actions they are way to verbose.
Member
Author
There was a problem hiding this comment.
Yep agree, for hover I'll tackle that problem(that is fix up tests in general) once I start refactoring it into multiple modules.
5 tasks
Member
Author
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #9868