Skip to content

fix: Don't seek outside of character boundaries in completion handler #10264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2021
Merged

fix: Don't seek outside of character boundaries in completion handler #10264

merged 1 commit into from
Sep 17, 2021

Conversation

@iDawer
Copy link
Contributor

@iDawer iDawer commented Sep 17, 2021

Fixes #10219 panic when entering : in $0 places:

fn main() {
    "⊞$0";
}
struct S {
    д$0 u8
}

@iDawer
fix completion handler trying to seek outside of character boundaries.
0ff271d 
With this patch, in these examples
```rust
fn main() {
    "⊞$0";
}
```

```rust
struct S {
д$0 u8
}
```
entering ':' character in `$0` places shouldn't cause panics.
@Veykril
Copy link
Member

Veykril commented Sep 17, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 17, 2021

Build succeeded:

@bors bors bot merged commit 5964750 into rust-lang:master Sep 17, 2021
@iDawer iDawer deleted the completion.suppress-at-column branch September 25, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

byte index is not a char boundary in string literal with non-ascii char

2 participants

@iDawer @Veykril