minor: simplify generics parsing #10283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @Veykril stared at it for half a day, and figured a way to say this nicer. |
Contributor
|
Build failed: |
Veykril
reviewed
Sep 19, 2021
Comment on lines
50
to
52
| let m = m.complete(p, PATH_SEGMENT).precede(p).complete(p, PATH); | ||
| let m = paths::type_path_for_qualifier(p, m); | ||
| m.precede(p).complete(p, TYPE_ARG); |
Member
There was a problem hiding this comment.
This is missing a PATH_TYPE now
matklad
force-pushed
the
simplify-generics-parsing
branch
from
fa83b96 to
09531b7
Compare
Contributor
Author
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bors r+
🤖