Skip to content

fix: Don't bail on parse errors in macro input for builtin expansion #10293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2021
Merged

fix: Don't bail on parse errors in macro input for builtin expansion #10293

merged 1 commit into from
Sep 19, 2021

Conversation

@Veykril
Copy link
Member

@Veykril Veykril commented Sep 19, 2021

Fixes #8158

@Veykril
Copy link
Member Author

Veykril commented Sep 19, 2021

bors r+

bors bot added a commit that referenced this pull request Sep 19, 2021
@bors @Veykril
Merge #10293
3af08f9 
10293: fix: Don't bail on parse errors in macro input for builtin expansion r=Veykril a=Veykril

Fixes #8158

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 19, 2021

Build failed:

@Veykril
Copy link
Member Author

Veykril commented Sep 19, 2021

bors retry

@bors
Copy link
Contributor

bors bot commented Sep 19, 2021

Build succeeded:

@bors bors bot merged commit f1d7f98 into rust-lang:master Sep 19, 2021
@Veykril Veykril deleted the builtin-macs branch September 19, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inside macros, methods don't show up in completion after a dot

1 participant

@Veykril