Skip to content

feat: Convert a/mod.rs into a.rs #10362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 28, 2021
Merged

feat: Convert a/mod.rs into a.rs #10362

merged 4 commits into from
Sep 28, 2021

Conversation

@longfangsong
Copy link
Contributor

@longfangsong longfangsong commented Sep 27, 2021

This is the reverse operation of #10211.

demo

Close #10143.

@lnicola
Copy link
Member

lnicola commented Sep 27, 2021

LGTM, but one nit: would you mind changing the label to Convert X to Y or Turn X into Y? It sounds a bit better.

Veykril
Veykril reviewed Sep 27, 2021
View reviewed changes
longfangsong and others added 4 commits September 28, 2021 10:20
@longfangsong
initial commit
0049b5b
@longfangsong @Veykril
Update crates/ide_assists/src/handlers/move_from_mod_rs.rs
8f5e8e0 
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
@longfangsong @Veykril
Update crates/vfs/src/vfs_path.rs
51b1f77 
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
@longfangsong
Address comments
7e3224f
@longfangsong longfangsong changed the title feat: Turn a/mod.rs into a.rs feat: Convert a/mod.rs into a.rs Sep 28, 2021
@Veykril
Copy link
Member

Veykril commented Sep 28, 2021

Thanks!
bors r+

@bors
Copy link
Contributor

bors bot commented Sep 28, 2021

Build succeeded:

@bors bors bot merged commit dd21ad6 into rust-lang:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Veykril Veykril Awaiting requested review from Veykril

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature request: Promote / Downgrade module

3 participants

@longfangsong @lnicola @Veykril