Skip to content

fix: renaming modules does not change references by super #11436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2022
Merged

fix: renaming modules does not change references by super #11436

merged 2 commits into from
Feb 8, 2022

Conversation

@TheDoctor314
Copy link
Contributor

@TheDoctor314 TheDoctor314 commented Feb 8, 2022 •
edited
Loading

Fixes #11289.

@TheDoctor314
Add test
add80bc 
The rename function should not change any path segments that refer to a
module by super.
@TheDoctor314
Fix renaming super keyword
10e7e18
@Veykril
Copy link
Member

Veykril commented Feb 8, 2022

Thanks!
bors r+

@bors
Copy link
Contributor

bors bot commented Feb 8, 2022

Build succeeded:

@bors bors bot merged commit 8ac4595 into rust-lang:master Feb 8, 2022
@TheDoctor314 TheDoctor314 deleted the rename-mod-ref-by-super branch February 9, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Renaming a module shouldn’t change path segments referring this module by super

2 participants

@TheDoctor314 @Veykril