Skip to content

Conversation

@jhgg
Copy link
Contributor

@jhgg jhgg commented Feb 8, 2022

this change renders in the autocomplete detail, whether a function is async/const/unsafe.

i found myself wanting to know this information at a glance, so now it renders here:

image

@Veykril
Copy link
Member

Veykril commented Feb 8, 2022

While I do think this is useful information, I fear that this might become too much information for the detail view(that is when not expanding the view).

Best way to realize whether that is the case or not is to just experiment with it though I think, so let's merge and see.

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 8, 2022

@bors bors bot merged commit 7c2d703 into rust-lang:master Feb 8, 2022
@jhgg
Copy link
Contributor Author

jhgg commented Feb 9, 2022

Luckily I think the pathological case of const async unsafe fn is very rare in practice, so this should probably never be a problem practically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants