fix(rename): Use text range of a mod name after macro expansion #11442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tysg
force-pushed
the
rename-mod-in-macro
branch
from
b407e78 to
e62e926
Compare
Veykril
reviewed
Feb 11, 2022
| file_id, | ||
| TextEdit::replace(name.syntax().text_range(), new_name.to_string()), | ||
| ), | ||
| _ => never!("Module source node is missing a name"), |
Member
There was a problem hiding this comment.
Any reason the never! is gone now?
crates/ide_db/src/rename.rs
Outdated
Comment on lines
192
to
198
| if let Some(file_range) = Definition::Module(module).range_for_rename(sema) { | ||
| source_change.insert_source_edit( | ||
| file_id, | ||
| TextEdit::replace(name.syntax().text_range(), new_name.to_string()), | ||
| ), | ||
| _ => never!("Module source node is missing a name"), |
Member
There was a problem hiding this comment.
I think instead of calling out to range_for_rename we can just add the missing src.with_value(name.syntax()).original_file_range_opt(sema.db) line here instead since we already have the decl_source anyways
Member
|
Thanks! |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11417.