fix: Fix Immovable generator syntax (static ||) not recognized #11448 #11458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
reviewed
Feb 12, 2022
lnicola
reviewed
Feb 12, 2022
| async || {}; | ||
| move || {}; | ||
| async move || {}; | ||
| static || {}; |
Member
There was a problem hiding this comment.
Can you also include static move || {};?
Contributor
There was a problem hiding this comment.
And also static async move ?
Contributor
Author
There was a problem hiding this comment.
You are right. I am going to had it too
lnicola
reviewed
Feb 12, 2022
Veykril
reviewed
Feb 13, 2022
Veykril
reviewed
Feb 14, 2022
|
|
||
| T![const] if (la == IDENT || la == T![_] || la == T![mut]) => consts::konst(p, m), | ||
| T![static] => consts::static_(p, m), | ||
| T![static] if (la == IDENT || la == T![_] || la == T![mut]) => consts::static_(p, m), |
Member
There was a problem hiding this comment.
Suggested change
| T![static] if (la == IDENT || la == T![_] || la == T![mut]) => consts::static_(p, m), | |
| T![static] if (la == IDENT || la == T![mut]) => consts::static_(p, m), |
underscore as name is not valid for statics
Contributor
Author
There was a problem hiding this comment.
Without test '_' i have a regression on tests :
tests::parse_inline_err for the file 0013_anonymous_static.rs
the error is not the expected one
Member
There was a problem hiding this comment.
Ah we recover in static_ from this, ye I guess this is fine then.
Member
|
Thanks! |
Contributor
Veykril
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.