Implement initial type-inference support for Index #1694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike ast::BinOp, it has significantly more structure to it, so it's easier to, say, handle all assignment-like operations in the same way.
matklad
commented
Aug 17, 2019
| /// The `..` operator for right-open ranges | ||
| RangeRightOpen, | ||
| /// The `..=` operator for right-closed ranges | ||
| RangeRightClosed, |
Contributor
Author
There was a problem hiding this comment.
We use separate RangeExpr for this
Member
|
LGTM, I like the reorganization of the binary ops! bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 17, 2019
1694: Implement initial type-inference support for Index r=flodiebold a=matklad This doesn't actually infer indexing types, but at least it walks sub-expressions! Initially, I wanted to make `Index` just a new kind of `BinOp` (b/c indexing is kind of a binary op), so I've refactoring binop handing a bit. However, in the end I've decided to add a separate expr kind for Index, because `foo[0]`, `&foo[1]` and `&mut foo[1]` all seem to need slightly different handing, which is not binop-like r? @flodiebold Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't actually infer indexing types, but at least it walks sub-expressions!
Initially, I wanted to make
Indexjust a new kind ofBinOp(b/c indexing is kind of a binary op), so I've refactoring binop handing a bit.However, in the end I've decided to add a separate expr kind for Index, because
foo[0],&foo[1]and&mut foo[1]all seem to need slightly different handing, which is not binop-liker? @flodiebold