fix: place new module outside impl block in extract_module
#20589
+92
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example
---
```rust
struct Foo;
impl Foo {
$0fn foo() {}
fn bar() {}$0
fn baz() {}
}
```
**Before this PR**:
```rust
struct Foo;
impl Foo {
mod modname {
pub(crate) fn foo() {}
pub(crate) fn bar() {}
}
fn baz() {}
}
```
**After this PR**:
```rust
struct Foo;
impl Foo {
fn baz() {}
}
mod modname {
use super::Foo;
impl Foo {
pub(crate) fn foo() {}
pub(crate) fn bar() {}
}
}
```
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
lnicola
changed the title
impl block in extract_module
mendelsshop
pushed a commit
to mendelsshop/rust-analyzer
that referenced
this pull request
Oct 27, 2025
Fix extract multiple item in impl for extract_module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example
Before this PR:
After this PR: