Migrate more stuff to the next solver #20841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bulk of the work is trait solving and cached in the trait solver's cache, and this will save memory.
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
commented
Oct 14, 2025
| ), | ||
| }; | ||
| // if the arg is error like, render it to inform the user | ||
| if is_err(arg) { |
There was a problem hiding this comment.
This was needed because params without default would have an error default, but now they just have None.
ChayimFriedman2
commented
Oct 14, 2025
|
|
||
| let sized_trait = LangItem::Sized.resolve_trait(db, resolver.krate()); | ||
| if let Some(sized_trait) = sized_trait { | ||
| let (mut generics, mut def_id) = |
There was a problem hiding this comment.
This code had a bug, that it thought the first param of an assoc item of a trait was Self (because it compared by index and not the owner def), therefore I rewrote it.
ChayimFriedman2
commented
Oct 14, 2025
| self.current_or_prev_segment = | ||
| segments.get(resolved_segment_idx).expect("should have resolved segment"); | ||
|
|
||
| if matches!(self.path, Path::BarePath(..)) { |
There was a problem hiding this comment.
This optimization had to be removed since now validation can fail on non-generic paths too (AdtSelf on param default).
ChayimFriedman2
commented
Oct 14, 2025
| *a* | ||
| ```rust | ||
| a: T |
There was a problem hiding this comment.
This code was erroneous, you cannot refer to Self in param default.
ShoyuVanilla
approved these changes
Oct 19, 2025
rustbot
removed
the
S-waiting-on-review
|
changelog fixup #20329 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing commit-by-commit is recommended.