Skip to content

fix: fix indent in add_missing_match_arms #20850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

fix: fix indent in add_missing_match_arms #20850

merged 1 commit into from
Oct 21, 2025

Conversation

@A4-Tacks
Copy link
Member

@A4-Tacks A4-Tacks commented Oct 16, 2025 •
edited
Loading

  • And fix indentations

Example

fn main() {
    match None$0 {
        None => {
            foo(
                "foo",
                "bar",
            );
        }
    }
}

Before this PR:

fn main() {
    match None {
        None => {
                foo(
                    "foo",
                    "bar",
                );
            }
        Some(${1:_}) => ${2:todo!()},$0
    }
}

After this PR:

fn main() {
    match None {
        None => {
            foo(
                "foo",
                "bar",
            );
        }
        Some(${1:_}) => ${2:todo!()},$0
    }
}

@A4-Tacks
Migrate add_missing_match_arms assist, because edit_in_place uses ted
ed428f1 
- And fix indentations

Example
---
```rust
fn main() {
    match None$0 {
        None => {
            foo(
                "foo",
                "bar",
            );
        }
    }
}
```

**Before this PR**:

```rust
fn main() {
    match None {
        None => {
                foo(
                    "foo",
                    "bar",
                );
            }
        Some(_) => todo!(),
    }
}
```

**After this PR**:

```rust
fn main() {
    match None {
        None => {
            foo(
                "foo",
                "bar",
            );
        }
        Some(${1:_}) => ${2:todo!()},$0
    }
}
```
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2025
@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Oct 21, 2025
Merged via the queue into rust-lang:master with commit 57875bd Oct 21, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2025
@A4-Tacks A4-Tacks deleted the add-mis-match-arms-indent branch October 21, 2025 05:10
@lnicola lnicola changed the title Migrate add_missing_match_arms assist, because edit_in_place uses ted fix: fix indent in add_missing_match_arms Oct 24, 2025
mendelsshop pushed a commit to mendelsshop/rust-analyzer that referenced this pull request Oct 27, 2025
@ShoyuVanilla
Merge pull request rust-lang#20850 from A4-Tacks/add-mis-match-arms-i…
3643535 
…ndent

Migrate `add_missing_match_arms` assist, because edit_in_place uses ted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShoyuVanilla ShoyuVanilla ShoyuVanilla approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@A4-Tacks @ShoyuVanilla @rustbot