Skip to content

Conversation

@ChayimFriedman2
Copy link
Contributor

Reviewing commit-by-commit is recommended. The second commit could use a more quick review, it was mostly following the compiler.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2025
Copy link
Member

@ShoyuVanilla ShoyuVanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I just realized how many unused params - mostly unimplemented/unnecessary trait impls from rustc_type_ir, which are fine - we have 😅

@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Oct 20, 2025
Merged via the queue into rust-lang:master with commit 9c494da Oct 20, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2025
@ChayimFriedman2 ChayimFriedman2 deleted the to-ns-almost-final branch October 20, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants