fix: Fix signature_help to proto conversion creating invalid utf16 offsets
#20876
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Was this found through the newly released Windows build of Zed? 😄 |
|
No we added new asserts which caught this, and then I realized r-a assumes characters are 2 bytes wide at most (which is wrong) |
rustbot
removed
the
S-waiting-on-review
Veykril
added a commit
to zed-industries/zed
that referenced
this pull request
Oct 20, 2025
…nt (#40707) The parameter label offsets are utf16 offsets, not utf8. Additionally we now validate the language server output. Closes #40578 Companion bug on rust-analyzer side rust-lang/rust-analyzer#20876 Release Notes: - Fixed `textDocument/signatureHelp` implementation not being LSP compliant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.