fix: fix array inhabitedness check #20905
Merged
+53
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
commented
Oct 24, 2025
| let r = match ty.kind() { | ||
| TyKind::Adt(adt, subst) => self.visit_adt(adt.def_id().0, subst), | ||
| TyKind::Never => BREAK_VISIBLY_UNINHABITED, | ||
| TyKind::Tuple(..) => ty.super_visit_with(self), |
There was a problem hiding this comment.
Tuple should be super-visited, as super-visit iterates over its field types
ShoyuVanilla
commented
Oct 24, 2025
| TyKind::Array(item_ty, len) => match try_const_usize(self.infcx.interner.db, len) { | ||
| Some(0) | None => CONTINUE_OPAQUELY_INHABITED, | ||
| Some(1..) => item_ty.super_visit_with(self), | ||
| Some(1..) => item_ty.visit_with(self), |
There was a problem hiding this comment.
But item_ty here should be directly visited
ChayimFriedman2
approved these changes
Oct 24, 2025
rustbot
removed
the
S-waiting-on-review
lnicola
changed the title
mendelsshop
pushed a commit
to mendelsshop/rust-analyzer
that referenced
this pull request
Oct 27, 2025
fix: Fix a bug on inhabitedness checks for arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18334