perf: Reduce client_commands allocations in proto conversion
#20922
+45
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
|
Are you sure it's a bottleneck? It's done once per request, and the requests are usually bottlenecked by inference etc., not by this. |
|
Well, the issue here was that for completions and code actions it was done once per completion item and code action item which is very much noticeable on profiling. So this is more about highlighting that there are perf traps with the structure of this code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our capability and config system fetching is hugely wasteful, allocating a bunch which becomes problematic in code paths like completions and code actions where we transform a bunch of entries. So this jus papers over one instance of this, but we should really fix this properly