Fix duplicate const complete after raw
#20937
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
41 tasks
| if !in_block_expr { | ||
| add_keyword("unsafe", "unsafe {\n $0\n}"); | ||
| add_keyword("const", "const {\n $0\n}"); | ||
| if !wants_const_token { |
Member
There was a problem hiding this comment.
While this is totally correct, it looks quite counter-intuitive as it adds a const token even though it says does not want a const token 😅 Could you add a brief comment addressing this?
Example
---
```rust
fn main() { let _ = &raw $0 }
```
**Before this PR**
```text
fn main() fn()
bt u32 u32
kw const
kw const
kw crate::
...
```
**After this PR**
```text
fn main() fn()
bt u32 u32
kw const
kw crate::
...
```
A4-Tacks
force-pushed
the
duplicate-raw-const
branch
from
bf59c35 to
6c75b7e
Compare
ShoyuVanilla
approved these changes
Nov 24, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example
Before this PR
After this PR